renkar/tipibot
1
0
Fork 0
forked from sass/tipibot
Code Pull Requests 2 Actions Activity

fix(teams): resolve dividers from tab name + full title, not last notice row #9

Merged
renkar merged 1 commits from feat/teamsync-reposition into master 2026-09-03 20:35:25 +00:00
Conversation 0 Commits 1 Files Changed 2 +25 -2
renkar commented 2026-09-03 20:35:13 +00:00
Owner
Copy Link

Section titles are stacked single-cell rows: the "TipiLAN 2026 CS2" title
sits above notice rows ("If a team withdraws..."), and parse_team_sections
kept only the LAST one, so the notice clobbered the title and resolve_divider
saw no game/year keywords -> None -> teams never positioned.

  • parse_team_sections now accumulates all single-cell rows above a header, so
    the game/year title survives alongside the notices.
  • refresh_teams_sync resolves the divider from "
    ",
    so the game is taken reliably from the CS2/LoL worksheet name while the year
    still comes from the title, keeping year-scoped TEAM_DIVIDER    *_2026 vars.
  • regression test: title survives notice rows and still resolves.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01XPRsW4tazVtYi2jNzVQkre

Section titles are stacked single-cell rows: the "TipiLAN 2026 CS2" title sits above notice rows ("If a team withdraws..."), and parse_team_sections kept only the LAST one, so the notice clobbered the title and resolve_divider saw no game/year keywords -> None -> teams never positioned. - parse_team_sections now accumulates all single-cell rows above a header, so the game/year title survives alongside the notices. - _refresh_teams_sync resolves the divider from "<tab name> <section title>", so the game is taken reliably from the CS2/LoL worksheet name while the year still comes from the title, keeping year-scoped TEAM_DIVIDER_*_2026 vars. - regression test: title survives notice rows and still resolves. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XPRsW4tazVtYi2jNzVQkre
renkar added 1 commit 2026-09-03 20:35:13 +00:00
fix(teams): resolve dividers from tab name + full title, not last notice row c19e67b5ab 
Section titles are stacked single-cell rows: the "TipiLAN 2026 CS2" title
sits above notice rows ("If a team withdraws..."), and parse_team_sections
kept only the LAST one, so the notice clobbered the title and resolve_divider
saw no game/year keywords -> None -> teams never positioned.

- parse_team_sections now accumulates all single-cell rows above a header, so
  the game/year title survives alongside the notices.
- _refresh_teams_sync resolves the divider from "<tab name> <section title>",
  so the game is taken reliably from the CS2/LoL worksheet name while the year
  still comes from the title, keeping year-scoped TEAM_DIVIDER_*_2026 vars.
- regression test: title survives notice rows and still resolves.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XPRsW4tazVtYi2jNzVQkre
renkar merged commit b813ed5f81 into master 2026-09-03 20:35:25 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
sass renkar
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: renkar/tipibot#9
Delete Branch "feat/teamsync-reposition"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?